Frontend - Login #27
Frontend - Login #27
Conversation
(one we made ourselves)
Also fixed alert styling padding
WishingWell13
requested review from
echang594,
jennymar and
alexzhang1618
as code owners
|
Thanks for contributing! |
|
Missing temp API stuff, if anyone has a reference please link |
| import styles from './style.module.scss'; | ||
| import Error from '../../../public/assets/error.svg'; | ||
| import { PropsWithChildren } from 'react'; | ||
|
|
||
| interface AlertProps { | ||
| marginBottom: 0 | 1 | 1.5 | 2; | ||
| } | ||
|
|
||
| const Alert = ({ marginBottom, children }: PropsWithChildren<AlertProps>) => { | ||
| return ( | ||
| <div className={styles.alert} style={{ marginBottom: `${marginBottom}rem` }}> | ||
| <div className="error"> | ||
| <Error /> | ||
| </div> | ||
|
|
||
| {children} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Alert; |
There was a problem hiding this comment.
If we're doing font stuff here might as well just use Typography. Also, what's the difference between this and useToast from portal-v2? If it's similar, let's just use toasts
There was a problem hiding this comment.
From the Figma it doesn't look like a pop up? Let me know if toasts can be non popup or if we want to change the error to a pop up
|
Desktop Desktop smaller window (I'll reorder error message when I get home) |
Background image in progress
|
See below for anchoring to bottom: https://stackoverflow.com/questions/5383438/keeping-background-image-at-bottom |
client/yarn.lock
Outdated
There was a problem hiding this comment.
Hm if nothing changed in package.json, why is this getting updated? Would recommend taking a look or regenerating this
There was a problem hiding this comment.
Unsure. Regenerated and still different.
Info
Closes #21. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Created frontend for login page
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.jsonfile.Screenshots
Please include a screenshot of your Postman testing passing successfully.